spiralhalo / LumiLights

Gameplay focused visual improvements for Canvas
GNU Lesser General Public License v3.0
124 stars 11 forks source link

Sun reflection looks too small #14

Closed spiralhalo closed 3 years ago

spiralhalo commented 3 years ago

image

Tricky problem.

  1. Is the sun sprite too big?
  2. Are the surfaces (e.g. water) not rough enough?
  3. Is the assumption that the sun is infinitely far away wrong?

Depends on the answer, it could have multiple solution.

  1. No clue.
  2. Clear water are very smooth. Should be < 0.1 which is the current situation. Not to mention defining minimum roughness would affect other light reflection, not just the sun.
  3. Possibly. However, sampling the sun as multiple (i.e. not just a single dot) light source has been tried, and resulted in terrible performance. Also, the multiple light source paradigm might break when a shadow map is later generated from a single POV.