search

spiralhalo / LumiLights

Gameplay focused visual improvements for Canvas
GNU Lesser General Public License v3.0
123 stars 11 forks source link

Weird handheld lighting issues with water #22

Closed supsm closed 3 years ago

supsm commented 3 years ago

I've accidentally found that handheld light sources are very bright on water. 2020-12-20_18 07 11 2020-12-20_18 09 23 2020-12-20_18 07 13

supsm commented 3 years ago

I forgot to mention that I was on v0.3 (not sure if 0.4 will make a difference)

spiralhalo commented 3 years ago

This bug is very weird. By chance did you switch between HDR and PBR version in the same session? Is the bug persistent or does it go away when you restart minecraft?

Currently I can't reproduce it reliably. Last time I encountered it, restarting minecraft fixed it. It's as if the bug is within minecraft, or the GL states, not sure. No error messages or anything.

If you found a hint to reliably reproduce it, please let me know.

supsm commented 3 years ago

I think I switched from Lumi HDR to Lumi PBR. I think I switched, then disconnected (but didn't close minecraft), then got on and found the bug. I'll do some more experiments when I have time later.

spiralhalo commented 3 years ago

The water wave generation in PBR and HDR are very slightly different, so that might be causing problem if the resource loader somehow mix them up. It should no longer be an issue in unified version since the water wave generation should be identical.

spiralhalo commented 3 years ago

For the time being, since it can only be reproduced via external force (switching resource packs) there isn't much I can do about it other than make people switch to unified.

If the problem persists in unified version (e.g. when turning PBR on/off in unified) or if there are other ways to reproduce this issue without switching resource pack, then please reopen the issue.

Meanwhile I won't stop you from commenting on this issue if you have related discussion. Thanks again for the report.

supsm commented 3 years ago

Would this be a canvas issue then? Should I report this in the canvas repo?

spiralhalo commented 3 years ago

For now, please switch to unified. I can guide you to config unified in order to get the old "edition" that you need if you ask on the discord.

I can't tell you what issue this is, only if it's worth fixing or not based on how frequent it happens. Switching from Lumi HDR to PBR probably don't happen very often, and like I said you don't need to do that anymore since the unified edition merges HDR and PBR together. Only reopen this issue if it recurs in the unified edition, then I can try to pinpoint the cause.