search

spiralhalo / LumiLights

Gameplay focused visual improvements for Canvas
GNU Lesser General Public License v3.0
124 stars 11 forks source link

Fix cloud stuttering (use render time instead of world time) #38

Closed TheArcaneBrony closed 3 years ago

TheArcaneBrony commented 3 years ago

This commit fixes cloud stuttering by making it not depend on world time, but rather on render time (just like vanilla Minecraft). You can see it in action here: https://youtu.be/gQSkw1CsvyE

supsm commented 3 years ago

Noooo, I can't make the clouds sync up anymore

TheArcaneBrony commented 3 years ago

Sync up with? It's fixing jerky clouds on servers (see video)

spiralhalo commented 3 years ago

Thanks for making this. After some quick maths with 1 Minecraft day = 20 minutes assumption, the clouds will be 1.5x faster in this PR. Does it matter though? I dunno. Thoughts?

Noooo, I can't make the clouds sync up anymore

"Hey go to 1200, 800 at midnight of tenth day. The clouds look like the four different shapes of Chicken McNuggets®."

(disclaimer: the clouds don't actually resemble the shapes of Chicken McNuggets® at that coords.)

spiralhalo commented 3 years ago

From testing it doesn't look too different. Good.

TheArcaneBrony commented 3 years ago

In case they're 1.5x faster, you could always divide the time by 1.5.