[classic] LUA error - compare two nil values

spiralofhope / SuperDuperMacro

[unmaintained] A World of Warcraft AddOn which enables the creation of incredibly long macros.

http://blog.spiralofhope.com/?p=18050

Other

13 stars 11 forks source link

[classic] LUA error - compare two nil values #28

Closed chrisblossom closed 4 years ago

chrisblossom commented 4 years ago

The following LUA error occurs every time I login WoW Classic:

Date: 2020-08-03 17:04:17
ID: 1
Error occured in: Global
Count: 1
Message: ...face\AddOns\SuperDuperMacro\SuperDuperMacro_Core.lua line 499:
   attempt to compare two nil values
Debug:
   [C]: ?
   ...face\AddOns\SuperDuperMacro\SuperDuperMacro_Core.lua:499: sdm_CompareVersions()
   ...face\AddOns\SuperDuperMacro\SuperDuperMacro_Core.lua:39:
      ...face\AddOns\SuperDuperMacro\SuperDuperMacro_Core.lua:30

Any ideas how to fix?

Thanks!

spiralofhope commented 4 years ago

I've seen that; it has to do with checking versions of the addon to import from old savedvariables.. I thought I had fixed that but I'll have to take another look.

chrisblossom commented 4 years ago

If there is anything I can do to help let me know. I would put a PR in to try and fix but am very unfamiliar with LUA.

spiralofhope commented 4 years ago

Well crap, I made a small mistake when I last investigated this. It should be fixed in retail_8.3.0.1,_classic_1.13.5.2 now.

https://github.com/spiralofhope/SuperDuperMacro/releases/tag/retail_8.3.0.1%2C_classic_1.13.5.2

chrisblossom commented 4 years ago

Looks like that fixed it! Thanks for getting that done so quickly!

spiralofhope commented 4 years ago

I'm glad it works.

Also, what does "put a PR in" mean? I looked around and can find usage with no real context to explain it.

chrisblossom commented 4 years ago

I PR in github terms means Pull Request. Basically if I knew how I would have fixed the code on my end then used github's pull request feature to ask you to merge the fixes into this repository.