search

spiralofhope / _DevPad.GUI

[unmaintained] A World of Warcraft addon: A notepad for Lua scripts and mini-addons. (GUI component)
http://blog.spiralofhope.com/?p=17397
Other
5 stars 1 forks source link

"Script ran too long" when shift + left clicking an item in your bags #31

Open ssateneth opened 4 years ago

ssateneth commented 4 years ago

Steps to reproduce

The game freezes and then generates an error.

error

From ssateneth:

Click to expand ``` `Message: Interface\AddOns\_DevPad.GUI\_DevPad.GUI.Editor.lua:82: script ran too long Time: Tue Oct 20 04:18:56 2020 Count: 1 Stack: Interface\AddOns\_DevPad.GUI\_DevPad.GUI.Editor.lua:82: script ran too long [string "@Interface\AddOns\_DevPad.GUI\_DevPad.GUI.Editor.lua"]:82: in function [string "=(tail call)"]: ? [string "=(tail call)"]: ? [string "=(tail call)"]: ? [string "=(tail call)"]: ? [string "=(tail call)"]: ? [string "=(tail call)"]: ? [string "=(tail call)"]: ? [string "=(tail call)"]: ? [string "=(tail call)"]: ? [string "=(tail call)"]: ? [string "=(tail call)"]: ? ... [string "=(tail call)"]: ? [string "=(tail call)"]: ? [string "=(tail call)"]: ? [string "=(tail call)"]: ? [string "=(tail call)"]: ? [string "@Interface\FrameXML\ItemButtonTemplate.lua"]:228: in function [string "=(tail call)"]: ? [string "@Interface\FrameXML\ContainerFrame.lua"]:1263: in function `ContainerFrameItemButton_OnModifiedClick' [string "*:OnClick"]:10: in function <[string "*:OnClick"]:1> [string "=[C]"]: ? Locals: Link = "[Embersilk Cloth]" (*temporary) = nil (*temporary) = nil (*temporary) = nil (*temporary) = nil (*temporary) = nil (*temporary) = nil (*temporary) = "script ran too long" NS = _DevPadGUIEditor { 0 = SetScriptObject = defined @Interface\AddOns\_DevPad.GUI\_DevPad.GUI.Editor.lua:308 FontIncrease = { } OnBackdropLoaded = defined @Interface\SharedXML\Backdrop.lua:205 GetBackdropColor = defined @Interface\SharedXML\Backdrop.lua:443 RightEdge = { } TEXT_INSET = 8 OnShow = defined @Interface\AddOns\_DevPad.GUI\_DevPad.GUI.Editor.lua:9 Bottom = { } FontPath = "Interface\AddOns\_DevPad.GUI\Skin\DejaVuSansMono.ttf" SetFont = defined @Interface\AddOns\_DevPad.GUI\_DevPad.GUI.Editor.lua:348 Run = { } ClearBackdrop = defined @Interface\SharedXML\Backdrop.lua:335 font_size_minimum = 6 History = { } Shortcuts = { } FontDecrease = { } SetupTextureCoordinates = defined @Interface\SharedXML\Backdrop.lua:267 HasBackdropInfo = defined @Interface\SharedXML\Backdrop.lua:331 font_size_steps = 1 GetEdgeSize = defined @Interface\SharedXML\Backdrop.lua:241 ChatEditInsertLink = defined @Interface\AddOns\_DevPad.GUI\_DevPad.GUI.Editor.lua:81 Edit = { } TopEdge = { } Font = _DevPadGUIEditorFont { } Title = { } BottomRightCorner = { } SetBackdropColor = defined @Interface\SharedXML\Backdrop.lua:452 LeftEdge = { } FontSize = 11 DefaultWidth = 500 font_size_maximum = 34 Focus = { } SetBackdropBorderColor = defined @Interface\SharedXML\Backdrop.lua:475 Resize = { } ScrollFrame = { } Pack = defined @Interface\AddOns\_DevPad.GUI\_DevPad.GUI.Editor.lua:676 BottomEdge = { } SetBackdrop = defined @Interface\SharedXML\Backdrop.lua:382 GetBackdropBorderColor = defined @Interface\SharedXML\Backdrop.lua:462 GetBackdrop = defined @Interface\SharedXML\Backdrop.lua:400 SetBorderBlendMode = defined @Interface\SharedXML\Backdrop.lua:319 Close = { } SyntaxColors =
{ } Window = { } AddTitleButton = defined @Interface\AddOns\_DevPad.GUI\_DevPad.GUI.Dialog.lua:63 OnBackdropSizeChanged = defined @Interface\SharedXML\Backdrop.lua:235 LastTitleButton = { } Center = { } Unpack = defined @Interface\AddOns\_DevPad.GUI\_DevPad.GUI.Editor.lua:687 default_font = "Interface\AddOns\_DevPad.GUI\Skin\DejaVuSansMono.ttf" Background = { } ScriptSetLua = defined @Interface\AddOns\_DevPad.GUI\_DevPad.GUI.Editor.lua:488 Lua = { } BottomLeftCorne` ```
spiralofhope commented 4 years ago

I found steps to reproduce this.

ssateneth commented 4 years ago

Sorry, seems all my github emails got sent to junk. Glad to see you were able to reproduce it.

ssateneth commented 3 years ago

I was able to remove the freezing by commenting out line 86 with "return ChatEdit_InsertLink( Link, ... )". I don't know what that broke with the addon by doing so but I can still use the addon normally.

edit: Had to comment out line 88 too, otherwise I couldnt link things in chat. Seems like its replacing a global function inserting links in chat with its own function.

spiralofhope commented 3 years ago

Thanks for the update and effort; I'll take a look.

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.