Quick n dirty fix for Intel Compiler Error (Possible bug)

[DanielSchuerhoff]

Contributor checklist

• [X] I have branched from the MASTER branch
• [X] My commit is 1 nicest logical chunk
• [X] My contribution is a half-baked and dirty hack, but should be merged as is!

---

Description

Dirty fix for bug occuring with Intel Compiler (Versions 17, 18, 19b) and OpenMP preventing Compilation Tested for successfull compilation (/w OpenMP but without CUDA) with:

• [X] Intel 18, 18.0.3.222,19_beta
• [X] gcc 7, 8
• [x] clang 5, 6

on centos-release-7-4.1708.el7.centos.x86_64

The Problem seems to be somewhere between the Intel Compiler and the n_cells_new, which is referenced from a const Geometry &. Using a local const int copy for the loops fixes the problem.

This Code fails to compile on:

• [ ] Intel 17: due to different problems: [ 71%] Building CXX object core/CMakeFiles/Spirit.dir/src/utility/Timing.cpp.o Internal error loop: assertion failed: find_seq_in_lookup_table: seq_number not found (shared/cfe/edgcpfe/il.c, line 4094)

[coveralls]

Coverage remained the same at 90.621% when pulling b87b3880e26ebad1c2fd60cd5f131feba6534450 on DanielSchuerhoff:master into 6f5a0c068e0f79adf62e889853b1171659ab2028 on spirit-code:master.

[codecov[bot]]

Codecov Report

Merging #422 into master will decrease coverage by 0.03%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   54.65%   54.62%   -0.04%     
==========================================
  Files          79       79              
  Lines        7624     7625       +1     
==========================================
- Hits         4167     4165       -2     
- Misses       3457     3460       +3

[DanielSchuerhoff]

Added the requested comment, clearing up the necessity of the local copy. Furthermore successfully tested compilation with Intel 18.0.3.222

[GPMueller]

I did not pay attention to this before, but you should not branch from master. The contribution guide, as well as the pull request template tell you to branch from develop...

I will not merge pull requests directly into the main release branch.

[GPMueller]

Changing the base branch also does not help, as it now includes all the release commits...