spirit-code / spirit

Atomistic Spin Simulation Framework
http://spirit-code.github.io
MIT License
120 stars 52 forks source link

Core: "Pythonification" of bindings #429

Closed GPMueller closed 6 years ago

GPMueller commented 6 years ago

Currently, the Python bindings are not only inconsistent, but also largely follow bad naming practices! See https://www.python.org/dev/peps/pep-0008/#naming-conventions Since we are already inconsistent, at some point the entire bindings should be straightened out and made consistent with the recommended standard.

Specifically:

GPMueller commented 6 years ago

Pythonified the spirit.constants module with 9152df3ace521dc2d2029d9fc1e778480dee1381 by turning the functions into module constants.

GPMueller commented 6 years ago

Pythonified the remaining bindings with 3c8288a20a9a5bbf3e4c9f102172e8fc54b79c1d on feature-improved-api.

GPMueller commented 6 years ago

Merged into develop with eb841c5bd39941d4c437895845969c00ff224f10.