Core: remove collection

spirit-code / spirit

Atomistic Spin Simulation Framework

http://spirit-code.github.io

MIT License

118 stars 52 forks source link

Core: remove collection #435

Closed GPMueller closed 6 years ago

GPMueller commented 6 years ago

[x] remove Collection APIs
[x] remove Spin_System_Chain_Collection
[ ] remove idx_chain from all API functions

Using multiple chains at the same time should be implemented on the UI-side, using multiple States. The only problem with this is that it makes transferring data between chains more difficult, but since the "collection" of chains was not yet implemented anyways, it does not reduce the features, but simplifies the API.

GPMueller commented 6 years ago

Removed APIs and class with cde699517b58d564b8ae3919431439f8706af758. Should remove the unnecessary chain index on branch feature-improved-api, starting from cde699517b58d564b8ae3919431439f8706af758.

GPMueller commented 6 years ago

Actually, as the chain is the highest container, it would make sense to allow multiple chains in the state. Copying images between chains may also be quite useful. The APIs could go e.g. into the State or Chain APIs.