search

spirit-code / spirit

Atomistic Spin Simulation Framework
http://spirit-code.github.io
MIT License
117 stars 52 forks source link

Error message: Tried to switch to previous image #465

Closed SpiritSuperUser closed 5 years ago

SpiritSuperUser commented 5 years ago

In my opinion, the Error message Tried to switch to previous image should be removed or replaced by a warning. I see the point, why it might be useful to see this message if it was triggered by the user and thus he/she should be warned, but it is also triggered in cases where the error message is misleading. For example: deleting an image triggers it (I guess to avoid that one is sitting on the last image and thus after deleting one faces a problem)

GPMueller commented 5 years ago

The issue when deleting an image is a bug in the API. This has been fixed with eafc8eee7bb7c9f8d5ddcc11f8d893c1121fe533. I think in cases where the user actually made a mistake, it makes sense to give an error message, as something might not be working as expected.