spirit-code / spirit

Atomistic Spin Simulation Framework

http://spirit-code.github.io

MIT License

118 stars 52 forks source link

Reworked FFT_Plan() to address issues with copying #469

Closed MSallermann closed 5 years ago

MSallermann commented 5 years ago

This pull request addresses issue #468. FFT_Plan has been reworked and

a proper constructor / copy constructor
move and copy assignment operators
a destructor

have been added. This should resolve the issues ocurring when the fft_plans get copied from one image to another. Additionally fft_plan_dipole() is now automatically freed because it is just temporarily allocated in Hamiltonian_Heisenberg::Prepare_DDI().

coveralls commented 5 years ago

Coverage remained the same at 84.545% when pulling efa8eacdb32eb037471a6f04d9c6371247a43734 on MSallermann:feature-DDI-FFT-clean into 09f909364d147b5c7e23cfae796b07215847a884 on spirit-code:develop.

codecov[bot] commented 5 years ago

Codecov Report

Merging #469 into develop will increase coverage by 0.01%. The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #469      +/-   ##
===========================================
+ Coverage    51.62%   51.63%   +0.01%     
===========================================
  Files           90       90              
  Lines         9833     9836       +3     
===========================================
+ Hits          5076     5079       +3     
  Misses        4757     4757