spirit-code / spirit

Atomistic Spin Simulation Framework
http://spirit-code.github.io
MIT License
117 stars 52 forks source link

Topological charge and surface visualisation fail for rectangular lattice with multiple basis atoms. #496

Closed GPMueller closed 5 years ago

GPMueller commented 5 years ago

The following input file is an example for this: input.txt

I assume that the problem is the Delaunay triangulation of Qhull, but I don't currently see why it would fail.

GPMueller commented 5 years ago

Strangely, for the same input file, a Qhull error can appear in the GUI, which comes from the isosurface visualisation - however, the isosurface should not do anything in the 2D case...

GPMueller commented 5 years ago

This should be fixed with e5d16f16dc90e34d94771edf51dbf363e5642a70.

The problem was that the Geometry class was calculating its dimensionality incorrectly as 3D in some 2D cases. This caused the 2D surface to crash in these cases and an isosurface could be activated but would also fail.