spirit-code / spirit

Atomistic Spin Simulation Framework
http://spirit-code.github.io
MIT License
117 stars 52 forks source link

Core: topological charge can be incorrect in special cases #510

Open GPMueller opened 5 years ago

GPMueller commented 5 years ago

While most issues were fixed with PR #495, the calculation still does not work for arbitrary geometries. Currently, there are two limitations:

This could be generalized with some programming effort. However, it is more important that the user be warned about the potentially incorrect results when these conditions are not fulfilled, so checks should be implemented.