Closed GPMueller closed 5 years ago
Fixed on branch 'hotfix' with 4c20f855f1670444b51610417c207481238cc1c2, to be merged into a new release. Note that the tri_positions
fix needs to be applied to the develop branch.
This should be fixed on master with release of v1.8.7 and on develop with 1043fa5220f2ba546403d25e96bd8acf7d67b929.
On MSVC, narrowing conversions are an error, while they are a warning on e.g. gcc. Issues arise when
float
is used as type forscalar
, because of code such asor
tri_positions[i] = {basis_cell_points[tri[i]].x, basis_cell_points[tri[i]].y, 0};
.This needs to be fixed in order to allow Windows builds of the CUDA version of Spirit.
Side note: for some reason gcc also narrows the
0.5
etc. in the assignment toVector3
without a warning, which makes it hard to find all occurences on a Linux system.