search

spirit-code / spirit

Atomistic Spin Simulation Framework
http://spirit-code.github.io
MIT License
117 stars 52 forks source link

Core: use CUB for reductions? #526

Closed GPMueller closed 4 years ago

GPMueller commented 5 years ago

There have been a few bugs related to different versions of compute capability and toolkit due to the handwritten implementation of warp reductions, it might be better to use CUB, see here for an example.

It is a reasonably compact library with a permissive license and easy to add to the project. It might be useful for other operations as well and could potentially speed up the code.

GPMueller commented 5 years ago

Added CUB to thirdparty folder with 11b4fcb85c262c45b89246835bef06fdabbe6f54 and started using with a1c049d97f44596a1f39b27be8543257c268633c on branch feature-ncg.

GPMueller commented 4 years ago

Added with 9ec7739078409b47b7bf1ea6053f4ab1fa0de95f on branch feature-new-minimisers (a continuation of feature-ncg), which has been merged with e818969fda25f3b3d2c6fc7239a692e19297f585.