spirit-code / spirit

Atomistic Spin Simulation Framework

http://spirit-code.github.io

MIT License

117 stars 52 forks source link

CMake improvements #565

Closed GPMueller closed 4 years ago

GPMueller commented 4 years ago

[x] closes #55
[x] closes #67
[ ] (TODO) #112
[x] closes #273

coveralls commented 4 years ago

Coverage remained the same at 79.423% when pulling f803f96dbbfd163aa4660fd6e11fa58bc4cb7b37 on improved-cmake into 5ca616a7771872170ce3771aed13138f91ad8597 on develop.

codecov[bot] commented 4 years ago

Codecov Report

Merging #565 into develop will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #565   +/-   ##
========================================
  Coverage    50.26%   50.26%           
========================================
  Files           88       88           
  Lines        10179    10179           
========================================
  Hits          5116     5116           
  Misses        5063     5063

GPMueller commented 4 years ago

Note that getting CUDA compilation running again with the new CMake features, i.e. without cuda_add_library, requires some restructuring. For potential future reference, I found these resources quite useful: