Update dependencies - Githubissues

spirit-code / spirit

Atomistic Spin Simulation Framework

http://spirit-code.github.io

MIT License

117 stars 52 forks source link

Update dependencies #630

Closed GPMueller closed 1 year ago

GPMueller commented 1 year ago

[x] update fmt
[x] update Eigen
[x] remove termcolors and replace with new fmt feature
[x] check for update of qhull and maybe update
[x] check for update of implot and maybe update
[x] check whether to remove cub -> yes, should be removed, is done on the improve-ci-add-nvcpp branch
[ ] update kissfft
[x] maybe update spectra
[ ] update imgui
[x] check for potential update of stb (getting C++17 deprecation warnings)

codecov[bot] commented 1 year ago

Codecov Report

Merging #630 (be1eac1) into develop (000eae7) will decrease coverage by 0.11%. The diff coverage is 63.69%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #630 +/- ## =========================================== - Coverage 49.06% 48.96% -0.11% =========================================== Files 76 77 +1 Lines 12065 12050 -15 =========================================== - Hits 5920 5900 -20 - Misses 6145 6150 +5 ```

coveralls commented 1 year ago

Coverage: 80.845%. Remained the same when pulling be1eac1a7b69c53e338cd02f862fdf29363505f2 on update-dependencies into 55d3d90fb15098ec7e4dc91ae2722ec71241594d on develop.

GPMueller commented 1 year ago

Updating kissfft led to NaNs in the DDI code, which I don't want to debug right now. Updating ImGUI to the current 1.89.6 docking branch (https://github.com/ocornut/imgui/commit/3418d509490c0f1dd4bc6c3ba2a9312e8efc0ff9) will cause the docking we implemented to not work correctly, so I created a branch update-imgui-docking-1-89-6).

This PR should be ready to be merged