search

spirit-js / spirit

Modern modular library for building web applications
http://spirit.function.run
ISC License
244 stars 18 forks source link

Typescript definitions #15

Open AJCStriker opened 7 years ago

AJCStriker commented 7 years ago

I'm thinking of adding some Typescript definitions to the project to offer a better developer experience for anyone working with Typescript.

Has any work been done on this yet and if not to what extent do you think this project should be integrated with Typescript ( A definition file vs adding types to the codebase )?

FlorianWendelborn commented 7 years ago

I'd say a definition file would be nice. Porting this project to TypeScript means that less people can understand it/contribute and that we're dependent on Microsoft.

@hnry What do you think?

hnry commented 7 years ago

There's no work being done on this, so if you're willing to work on this whether partially or full, it'll be great. I think definition files are the way to go. If there's any question or any help is needed let me know.