spiritix / lada-cache

A Redis based, fully automated and scalable database cache layer for Laravel
MIT License
538 stars 68 forks source link

Support laravel 8 #100

Closed miraries closed 4 years ago

miraries commented 4 years ago

Not sure if you want to make old laravel versions incompatible since no changes in the actual package were made but I see that was done for the previous version so:

spiritix commented 4 years ago

Hi @miraries. Sorry for the late reply, missed this PR somehow. Thanks a lot for the contribution, it's greatly appreciated. The question is - does the updated version still work with Laravel 7? If so, there is no need in making it incompatible.

miraries commented 4 years ago

Hey! That's ok. From what I could gather it should still work with Laravel 7. The breaking changes are only in the tests due to factories. Also I haven't run into any issues running it on Laravel 8 since making this PR.

I will update the dependencies and check later just in case.

spiritix commented 4 years ago

Then we should set the minimum dependencies to Laravel 7, but keep them on Laravel 8 for development environment. Like this the tests will pass and we don't make L7 incompatible.

abishekrsrikaanth commented 4 years ago

if we update the composer dependencies to support L7 and L8, wont we be good with the upgrade? Currently the composer dependencies only allow L7 support. We can still make a separate release so it will start supporting L8

abishekrsrikaanth commented 4 years ago
    "require": {
        "php": ">=7.2|7.3",
        "illuminate/support": "^7.0|^8.0",
        "illuminate/database": "^7.0|^8.0",
        "illuminate/redis": "^7.0|^8.0"
    },
    "require-dev": {
        "phpunit/phpunit": "^8.0|^9.0",
        "orchestra/testbench": "^5.1|^6.0",
        "mockery/mockery": "^1.3",
        "barryvdh/laravel-debugbar": "^3.2"
    },
miraries commented 4 years ago

Updated the dependencies and the readme, check when you can @spiritix

spiritix commented 4 years ago

Thanks a lot, guys. Will publish a new release as soon as I've tested everything.