search

spiritix / php-chrome-html2pdf

A PHP library for converting HTML to PDF using Google Chrome
MIT License
112 stars 29 forks source link

Actions and Version Requirements #47

Closed limenet closed 2 years ago

limenet commented 2 years ago

While using this package in a Pimcore context, I encountered a few rough edges, some of which have already been fixed, e.g. #42 -- thanks! Currently, the automated tests do not work since Travis CI no longer offers that service and the Node.js requirements are stricter than what is required by Puppeteer itself. Additionally, there were some font rendering issues which are fixed by adding a CLI flag. This PR addresses those aspects. I hope that's okay with you :)

Thanks for your package and let me know if you'd like me to make any changes!

spiritix commented 2 years ago

Thanks for the pull request @limenet, very appreciated. Added a few comments. If you further want to contribute to the repo, have a look at the open issues: https://github.com/spiritix/php-chrome-html2pdf/issues. I think the most requested feature would be the ability to pass custom options to Puppeteer.

limenet commented 2 years ago

@spiritix you're very welcome and thank you for your review!

I think the most requested feature would be the ability to pass custom options to Puppeteer.

There's a good chance this will be a requirement at work in the foreseeable future and if so, I'd be more than happy to work on that feature.