spiritualized1997 / openFPGA-NES

NES core for openFPGA on Analogue Pocket
188 stars 5 forks source link

SMB3 Romhacks with Battery Save not Working #4

Open Nam-Ereh-Won opened 2 years ago

Nam-Ereh-Won commented 2 years ago

First I verified I had the correct ROM version(s) and matched the hash to the listings on the following romhacks: Super Mario Ultimate Mario Adventure

I was able to successfully patch the ROMs and test in an emulator on my PC prior to loading them onto my Pocket.

In Mario Adventure, the music plays, but input is unresponsive and the screen is black. In Super Mario Ultimate, it's stuck in a boot loop. After displaying the "THIS HACK IS NOT TO BE SOLD!" screen, the graphics get scrambled and it goes unresponsive.

GreatHierophant commented 2 years ago

Copy over a 8192 byte .sav file with all 00s in it, these hacks do not work well unless the SRAM is cleared when they boot for the first time.

Nam-Ereh-Won commented 2 years ago

I took a look at the save files that were generated when starting the games. The one for Mario Adventure was zero'd out until byte 0x1000 and FF'd the rest of the way. The one for Super Mario Ultimate was all FF'd. Zeroing out the save file for both resulted in functioning games!

tarikalmashni commented 2 years ago

Interesting. If it can't be fixed in the core itself, at least a core option to "empty save file" would be nice, doing basically just that (overwriting everything with 00s) so it works after restarting the game instead of having to take this save file to a PC and edit it there.