search

spiroid / pelican-hpstr

Port of jekyll-hpstr-theme to pelican
GNU General Public License v2.0
4 stars 3 forks source link

Outdated copy of FontAwesome included #5

Closed esafak closed 10 years ago

esafak commented 10 years ago

The included version, 3.1, is from last year. The current version is 4.1, and includes useful new social icons, such as Stack Exchange. It would be useful to users to explain in the documentation that they can add social icons for any service that's included in this list by simply writing the part that comes after the fa- prefix.

spiroid commented 10 years ago

The version of FontAwesome included is 4.1.0. You can check this by reading the header of the font awesome css file

 *  Font Awesome 4.1.0 by @davegandy - http://fontawesome.io - @fontawesome

I'll add a link to font awesome documentation from the readme file to make it clear to users how to insert icons.

esafak commented 10 years ago

It's the actual fonts that are outdated, not the CSS. You might want to merge or at least look at my fork, which fixes this problem, and has some other features too.

spiroid commented 10 years ago

@esafak, can you please check that the issue is fixed by the commits in the referenced pull request ?

thx

esafak commented 10 years ago

I checked the OTF and TTF. Looks good. You can close this upon merging.

spiroid commented 10 years ago

ok thx for the feedback