Susheel raised an issue regarding data sources duplication. The duplication was caused because of different data source names in the markdown files (phenotype definition files) of github repository - making link not workable to jump to healthdatagateway as well. They are fixed now in this PR. Would you please review them and merge so when Ieuan make next import into the HDR UK phenotype library they should not appear as duplicate.
I have also added a codelist file (i.e. _data/codelists/Paige_CardiovascularDisease_ZAe8LVnjUBE6urqrGVJeRw_Read2.csv) that Ieuan mentioned was missing.
There is one issue left that I have not resolved is related to a phenotype "Homelessness" having (UUID: euGPKyQD9uAWWzUPmB7gV5 ). The data source is set as "primary care". Would you please look into this and fix this issue (should we say this as CPRD GOLD or CPRD Aurum or any other). It is important to mention that there is no publication for this phenotype. URL: https://portal.caliberresearch.org/phenotypes/luchenski-homelessness-eugpkyqd9uawwzupmb7gv5#implementation
Apparently the changes I made should pass all tests but it looks like last three commits are not passing tests on this PR.
Hi Spiros,
Susheel raised an issue regarding data sources duplication. The duplication was caused because of different data source names in the markdown files (phenotype definition files) of github repository - making link not workable to jump to healthdatagateway as well. They are fixed now in this PR. Would you please review them and merge so when Ieuan make next import into the HDR UK phenotype library they should not appear as duplicate.
I have also added a codelist file (i.e. _data/codelists/Paige_CardiovascularDisease_ZAe8LVnjUBE6urqrGVJeRw_Read2.csv) that Ieuan mentioned was missing.
There is one issue left that I have not resolved is related to a phenotype "Homelessness" having (UUID: euGPKyQD9uAWWzUPmB7gV5 ). The data source is set as "primary care". Would you please look into this and fix this issue (should we say this as CPRD GOLD or CPRD Aurum or any other). It is important to mention that there is no publication for this phenotype. URL: https://portal.caliberresearch.org/phenotypes/luchenski-homelessness-eugpkyqd9uawwzupmb7gv5#implementation
Apparently the changes I made should pass all tests but it looks like last three commits are not passing tests on this PR.
Regards, Shahzad