search

spirosikmd / angular2-focus

Angular attribute directive that gives focus on an element depending on a given expression 🔎
MIT License
21 stars 3 forks source link

Upgrading the version to the latest #26

Closed saiyaff closed 7 years ago

saiyaff commented 7 years ago

Since the version has upgraded to version 4 upgrading the application to angular v4 might help the community

spirosikmd commented 7 years ago

Hi @msaiyaff! I've already updated it to use angular v4, check the package.json. Maybe you tried it and something is not working? Thanks!

saiyaff commented 7 years ago

My bad. Couldn't have a look at it. Unfortunately, when I integrated this with the app, this was not working. I am trying to focus an input field in a modal, when a modal pops up. Any clue?

spirosikmd commented 7 years ago

Thank you for the extra information! Can you please provide an example so I can reproduce it? Otherwise, I could try myself?

spirosikmd commented 7 years ago

@msaiyaff have you used any kind of modal library? I can then try reproducing the issue using the same library? Thanks!

saiyaff commented 7 years ago

Sorry for hanging a bit @spirosikmd Just using it with bootstrap modal. 😄 I'll just add a snippet or some code and share the link here? Might need some time though

spirosikmd commented 7 years ago

Thanks @msaiyaff! I would much appreciate it! I can give it a try as well. Are you using a specific library for boostrap modal?

spirosikmd commented 7 years ago

@msaiyaff #32 implements an example using angular bootstrap modal. The input element is focused when modal is opened. Everything seems to work. Are you trying to implement something like this? Is your case more complex? Thanks!