Adapt code for the latest (0.132.2) version of three js

spite / THREE.MeshLine

Mesh replacement for THREE.Line

MIT License

2.16k stars 380 forks source link

Adapt code for the latest (0.132.2) version of three js #143

Closed NZhuravlev closed 2 years ago

NZhuravlev commented 3 years ago

Replace functions with classes
Remove Geometry class usage
Remove getInverse Matrix4 method usage

wouterverweirder commented 3 years ago

Confirming this works, would be nice to see this merged :-)

doeg commented 3 years ago

I've also confirmed that this fix works with three.js v.0.133.0, specifically with respect to https://github.com/spite/THREE.MeshLine/issues/139. :)

tiye commented 3 years ago

ping @spite

robksawyer commented 2 years ago

@spite where you at? Let's get it!

Zaniyar commented 2 years ago

how can I test this branch with npm in the meanwhile?

with this hash commit its same error: "three.meshline": "https://github.com/spite/THREE.MeshLine.git#168f9b28a9cf1f123df874d2d253872cadfa209c",

jrmahechad commented 2 years ago

interested in this update

Grepsy commented 2 years ago

how can I test this branch with npm in the meanwhile?

with this hash commit its same error: "three.meshline": "https://github.com/spite/THREE.MeshLine.git#168f9b28a9cf1f123df874d2d253872cadfa209c",

That's the current branch, you need the branch with the changes, like this:

"three.meshline": "https://github.com/NZhuravlev/THREE.MeshLine.git#358d2f801de9b80f0708fbf4f2868a9ac7aa381c"

spite commented 2 years ago

I've merged the PR and published to npm. Can someone confirm it's working?

tiye commented 2 years ago

a least it is working(THREE.Line at left, MeshLine at right):

Meanwhile there's a warning in Vite since the code not using ES Modules(I guess):

WARNING: Multiple instances of Three.js being imported.