Correct line widths in any circumstances

spite / THREE.MeshLine

Mesh replacement for THREE.Line

MIT License

2.16k stars 380 forks source link

Correct line widths in any circumstances #73

Closed axion014 closed 4 years ago

axion014 commented 5 years ago

subset of #101.

spite commented 5 years ago

Hi! Thanks for the PR. I tested it and the graph.html example doesn't work as expected. Is there anything I'm missing?

axion014 commented 5 years ago

The Graph demo were coded for current bugged MeshLine. I didn't see why sizeAttenuation should be disabled here as line width is meant to be constant regardless of camera zooming, so I turned it to false(this syntax should definitely be reversed).

trusktr commented 4 years ago

Hello! Can you explain what this does? Can you explain before/after?

axion014 commented 4 years ago

Shader math is complicated and I mostly forgot what this does, but it basically fixes #26, making lineWidth behavior consistent between both type of cameras.