spite / ccapture.js

A library to capture canvas-based animations at a fixed framerate
MIT License
3.55k stars 406 forks source link

Why are you overriding window namespace functions ? #101

Open jeanbmar opened 4 years ago

jeanbmar commented 4 years ago

I don't understand why you are overriding window functions in _init method, instead of creating and exposing wrappers on those. It's a potential disaster for libraries that use them. e.g. the requestAnimationFrame implementation messes with the DOMHighResTimeStamp parameter value and breaks any existing code that is running it.