spjeff / spbestwarmup

Tired of waiting for SharePoint pages to load? Want something easy to support? That works on all versions? This warmup script is for you!
2 stars 0 forks source link

String concatenation bug in WOPI services loop #36

Closed drullo closed 1 year ago

drullo commented 1 year ago

In WarmUp, the concatenation logic on lines 494 and 495 is incorrect - resulting in incomplete URLs that only include the protocol prefix and the hostname.

One possible solution is to wrap the content in parenthesis. This is what I chose to do in my environment: NavigateTo ("https://$w"+":810/$s/")

Another possible solution is to make it a single string (no plus sign) and prefix the colon with an escape character: NavigateTo "https://$w`:810/$s/"

spjeff commented 1 year ago

Excellent ideas Dan. Thank you. Updated with https://github.com/spjeff/spbestwarmup/commit/c40298d3f3436d6d061c66c9267944aa266242f8