search

spjeff / sppatchify

SharePoint Patchify - centralized tool to apply CU patch to entire farm from one console
MIT License
1 stars 0 forks source link

CopyExe not using -asJob #33

Open MSIH opened 4 years ago

MSIH commented 4 years ago

the CopyExe has code to monitor jobs https://github.com/spjeff/sppatchify/blob/75120d017d79f1b7ca76853d252dbc8273b93ea3/SPPatchify.ps1#L142

But the robocopy command is not invoked with -asJob

Aprazeth commented 4 years ago

That may be to avoid network congestion. Those SharePoint updates can be quite large (I know, I hail from an era that considered 500 MB large :-) ) and sending those out to a lot of servers at the same time could severely hamper performance - since not everyone has a high bandwidth available all the time.

That said, I could see that having a possibility to maybe switch it as such (i.e.; user provides a parameter/switch that instructs function CopyExe to invoke RoboCopy with -AsJob ) would be a good middle ground.