search

spkenv / spk

A Package Manager for high velocity software environments, built on spfs.
https://spkenv.dev
Apache License 2.0
40 stars 6 forks source link

Use MS_SLAVE instead of MS_PRIVATE when starting a new namespace #1025

Closed rydrman closed 5 months ago

rydrman commented 6 months ago

This is addressing 2 issues:

  1. We had some complaints that USB media was not visible from spfs shells once inserted, which this solves by allowing the new mount under /media to propagate into the namespace
  2. We had issues on el9.3 (alma) where autofs would unmount an expired mount point which would make it go away in the namespace, but then when it got remounted it would never reappear in the spfs shell. We're not sure why this was working in CentOS 7, but in any case this change more accurately describes the behaviour that we want to achieve.
rydrman commented 6 months ago

Thanks, seems like a case where /spfs does not exist yet and so the is_mounted query errors out. I've added code to handle this ENOENT case gracefully

rydrman commented 6 months ago

I'm just going to give this one a couple of days to see if any bad feedback comes in before merging

rydrman commented 5 months ago

Still no issues for us so I'm going to merge this