spkenv / spk

A Package Manager for high velocity software environments, built on spfs.
https://spkenv.dev
Apache License 2.0
40 stars 6 forks source link

Ensure edits saved into platforms are still present when run later #1045

Closed dcookspi closed 5 months ago

dcookspi commented 5 months ago

This changes the order that rendered layer's dirs are added to the mount -t overlay -o ... command line. It reverses the previous order. This makes it consistent with the way the mount command applies the layered directories when setting up overlayfs. This ensures edits saved into the top most layer of a platform are retained when the platform is used in a later spfs run... command. Previously those kinds of edit were clobbered by the other lower layers, which was not intended.

This adds a test to check edits saved into platforms are still present when the platform is used/run later.

dcookspi commented 5 months ago

Mentioning @rydrman because it won't let me add another reviewer.