spkenv / spk

A Package Manager for high velocity software environments, built on spfs.
https://spkenv.dev
Apache License 2.0
34 stars 5 forks source link

Use Cow to avoid annotation cloning #1075

Closed rydrman closed 2 months ago

rydrman commented 2 months ago

Annotations are built into flatbuffers, which typically requires a copy from the source string into the buffer. Previously, we were cloning strings an additional time into the annotation builder/value structs which we can now avoid in most circumstances by using a Cow::Borrowed instance.

resolves #986

requires additional spelling fixes from #1071

rydrman commented 2 months ago

also tagging @dcookspi