spkenv / spk

A Package Manager for high velocity software environments, built on spfs.
https://spkenv.dev
Apache License 2.0
34 stars 5 forks source link

[BUG] validation attribut disable is deprecated in gmp.spk, gcc63.spk and gcc93.spk #1089

Open doubleailes opened 1 month ago

doubleailes commented 1 month ago

Describe the bug validation attribut disable is deprecated but still present in the following spk.yaml

To Reproduce Steps to reproduce the behavior:

Running version 0.42.0

  1. Go to the root of spk
  2. run make packages
  3. See error

Expected behavior make cmd running without error and previous and building the previous listed packages

doubleailes commented 1 month ago

here is a PR to fix this: https://github.com/spkenv/spk/pull/1090

rydrman commented 1 month ago

Thanks for the PR! I think there's a tweak needed, but let me know if your changes are working - it's possible that some of the validation disabling is no longer needed...

doubleailes commented 1 month ago

Add more detail about the validation error

$ make packages
make -C packages packages
make[1]: Entering directory '/home/philippe.llerena/workspace/github.com/doubleailes/spk/packages'
spk info -r local gnu/gmp.spk.yaml@sources > /dev/null 2>&1 || spk make-source -v gnu/gmp.spk.yaml
spk mkb -r origin -v gnu/gmp.spk.yaml
DEBUG relaunching under spfs
 INFO saving package recipe for gmp/6.2.0
 INFO building binary package(s) for gmp/6.2.0
 INFO building variant index 0:
Options: {arch=x86_64, distro=rocky, os=linux, rocky=9.4}
Additional Requirements:  None
DEBUG variant options: {arch: x86_64, distro: rocky, os: linux, rocky: 9.4}
DEBUG   build options: {arch: x86_64, centos: , distro: rocky, gcc: , make: , os: linux, rocky: 9.4, stdfs: }
DEBUG Resolving source package for build
> RESOLVE gmp/6.2.0/src  (requested by gmp/6.2.0/src source build)
DEBUG Unchanged solver has finished first. Stopped remaining solver tasks.
Installed Packages:
  Package                   Version  Newest  Requested by  
  local/gmp:src/=6.2.0/src  6.2.0    -       gmp/6.2.0/src source build  
 Number of Packages: 1
DEBUG Resolving build environment
> RESOLVE stdfs/1.1.0/PF6B6TLF  (requested by gmp/6.2.0/HAQWUSQB binary build)
>> RESOLVE make/0.0.0+bootstrap.1/35MFBJT5  (requested by gmp/6.2.0/HAQWUSQB binary build)
>>> RESOLVE gcc/11.4.1/PSIJV77C  (requested by gmp/6.2.0/HAQWUSQB binary build)
DEBUG All Impossible Checks solver has finished first. Stopped remaining solver tasks.
Installed Packages:
  Package                                       Version            Newest  Requested by  
  local/stdfs:{build,run}/=1.1.0/PF6B6TLF       1.1.0              -       gcc/11.4.1/PSIJV77C, make/0.0.0+bootstrap.1/35MFBJT5, gmp/6.2.0/HAQWUSQB binary build  
  local/make:build/=0.0.0+bootstrap.1/35MFBJT5  0.0.0+bootstrap.1  -       gmp/6.2.0/HAQWUSQB binary build  
  local/gcc:build/=11.4.1/PSIJV77C              11.4.1             -       gmp/6.2.0/HAQWUSQB binary build  
 Number of Packages: 3
 INFO The All Impossible Checks solver found a solution, but its output was disabled. To see its output, rerun the spk command with '--solver-to-run checks'
ERROR (link)

  × Use of obsolete validators via 'build.validation.disabled'
  help: Replace them with the new 'build.validation.rules', as appropriate. https://spkenv.dev/ref/spec/#validationspec

make[1]: *** [Makefile:89: gnu/gmp.spk] Error 1
make[1]: Leaving directory '/home/philippe.llerena/workspace/github.com/doubleailes/spk/packages'
make: *** [Makefile:35: packages] Error 2