search

spkesDE / com.spkes.telegramNotifications

GNU General Public License v3.0
4 stars 5 forks source link

Check topic id if chat is a topic #23

Closed enyineer closed 1 year ago

enyineer commented 1 year ago

Fixes my request for fix comment in #14

enyineer commented 1 year ago

I also found a bug when sending questions to topics. The message_thread_id field was missing in that case. That's fixed now. Questions can now be sent to topics.

@spkesDE please have a look. Thank you!

spkesDE commented 1 year ago

Looks good, but I would change it so it a own card, so users don't get confused. if you want to do it feel free, or I'll do it once I find some time.

enyineer commented 1 year ago

Sure, I'll give it a try tomorrow after work 😃 Happy to help.

Still new to Homey apps (though I do have NodeJS and React knowledge) so I'd appreciate any tips and recommendations for Homey App programming for this PR.

enyineer commented 1 year ago

@spkesDE

Things I've improved:

  1. Removed topics from Chat Trigger Autocompletion pr-2
  2. Added a Trigger Card specifically for Topics pr-3
  3. I did also change multiple args titles / translations from "User" to "Chat / Topic" as they can be either a private Chat, Group Chat or Topic
  4. Action Cards still include both Chats and topics as it would probably become too confusing having duplicated Actions for Chats and Topics (just the quantity of Cards that would result by splitting them up).
spkesDE commented 1 year ago

https://homey.app/de-de/app/com.spkes.telegramNotifications/Telegram/test/

Deine Änderungen sind nun im Test Branch.

Erstmal danke für die Umsetzung und Hilfsbereitschaft. Die Änderungen sehen für mich als "hobby" Entwickler gut aus. Ich hab dich in den Mitwirkende hinzugefügt. Ich hoffe das es okay für dich.

Falls du mehr Ideen hast oder was besprechen willst kannst du mir gerne auf Telegram schreiben. https://t.me/julian022

enyineer commented 1 year ago

Alles klar, danke dir 🙂 Vielleicht finde ich bei intensiver Nutzung der App noch andere Dinge die wir zukünftig optimieren können / wollen. Ich helfe da auf jeden Fall gerne aus wenn du etwas hast wo ich aushelfen kann.