search

spknetwork / video-encoder

5 stars 3 forks source link

Validate Support For Node.JS 18 #31

Open Rishi556 opened 1 year ago

Rishi556 commented 1 year ago

Node 16 stops receiving security support in about 5 months(Sept 11 2023 https://endoflife.date/nodejs). Ensuring everything works on Node 18 before then should be done.

Rishi556 commented 1 year ago

Bug on 18:

7|video  | Startup: Checking if IPFS is running
7|video  | Logged in with did:key:z6MkqEEGCJE46cqdiBf9BydAp4APDVh7RcVte9HAEeBsanmd
7|video  | IPFS Daemon Not Available. Please run IPFS.
7|video  | []

This is most likely related to IPFS not listening on [::1] for it's api and Node18 changes DNS to stop reordering to have IPv4 be first(https://github.com/nodejs/node/pull/39987). An issue has been filed on Kubo's repo for this issue: https://github.com/ipfs/kubo/issues/9637. Hopefully IPFS fixes the issue on their end, but we should figure out where the connecting is attempting to be made, and change it to 127.0.0.1 for now.

vaultec81 commented 1 year ago

Bug on 18:

7|video  | Startup: Checking if IPFS is running
7|video  | Logged in with did:key:z6MkqEEGCJE46cqdiBf9BydAp4APDVh7RcVte9HAEeBsanmd
7|video  | IPFS Daemon Not Available. Please run IPFS.
7|video  | []

This is most likely related to IPFS not listening on [::1] for it's api and Node18 changes DNS to stop reordering to have IPv4 be first(nodejs/node#39987). An issue has been filed on Kubo's repo for this issue: ipfs/kubo#9637. Hopefully IPFS fixes the issue on their end, but we should figure out where the connecting is attempting to be made, and change it to 127.0.0.1 for now.

We had an similar issue to this when testing PoA. Just need to explicitly set the API url to 127.0.0.1 across the entire project code base and we should be good to go. I'd say it's always better to explicitly define where it's expected to listen on rather than letting the language assume.

Rishi556 commented 1 year ago

Bug on 18:

7|video  | Startup: Checking if IPFS is running
7|video  | Logged in with did:key:z6MkqEEGCJE46cqdiBf9BydAp4APDVh7RcVte9HAEeBsanmd
7|video  | IPFS Daemon Not Available. Please run IPFS.
7|video  | []

This is most likely related to IPFS not listening on [::1] for it's api and Node18 changes DNS to stop reordering to have IPv4 be first(nodejs/node#39987). An issue has been filed on Kubo's repo for this issue: ipfs/kubo#9637. Hopefully IPFS fixes the issue on their end, but we should figure out where the connecting is attempting to be made, and change it to 127.0.0.1 for now.

We had an similar issue to this when testing PoA. Just need to explicitly set the API url to 127.0.0.1 across the entire project code base and we should be good to go. I'd say it's always better to explicitly define where it's expected to listen on rather than letting the language assume.

It's a simple fix by modifying the config file the for the IPFS side of things, and I'll submit a PR there after doing some testing locally.