spl0k / supysonic

Supysonic is a Python implementation of the Subsonic server API.
https://supysonic.readthedocs.io
GNU Affero General Public License v3.0
260 stars 57 forks source link

Support cover art for the m4a file format #196

Closed PhilipVis closed 3 years ago

PhilipVis commented 3 years ago

Would it be possible to add support to retrieve cover art information embedded to m4a files? M4a files don't support the ID3 tags used by other music file formats, but they use XMP instead. This Stackoverflow answer has some information about it and the Mutagen library to use for m4a files.

spl0k commented 3 years ago

@baldurmen I'm considering using MediaFile, a wrapper around mutagen which will be used by a future version of beets. I noticed it doesn't exist (yet) in Debian, would that be a problem wrt packaging?

baldurmen commented 3 years ago

@spl0k Thanks for the heads-up! I would have to package it, but:

So no red flags for me. When you decide to use it, please ping me again and I'll start packaging it. Note it will delay me updating supysonic in Debian as new packages have to be manually reviewed by the FTP-masters team for copyright QA reasons.

spl0k commented 3 years ago

Would the freeze planning for bullseye delay even more if we were to add the new dependency before the transition/soft freeze? (I'm not sure which one applies to supysonic) I have to run (or write) some additional tests but the change is ready to be pushed.

baldurmen commented 3 years ago

You can't really push a new dependency to the archive during the soft-freeze if you don't have a very good reason for it. It's possible to do that during the transition, but I would be against packaging anything that isn't trivial or very well maintained, as if something needs to be corrected later it'll be a mess.

I have to run (or write) some additional tests but the change is ready to be pushed.

Good to know! I'll start packaging mediafile then.

baldurmen commented 3 years ago

https://ftp-master.debian.org/new/python-mediafile_0.6.0-1.html

:)

spl0k commented 3 years ago

0183bcb69846471d2ba0c3ae7277e1a504e8b003 ;)