search

spl0k / supysonic

Supysonic is a Python implementation of the Subsonic server API.
https://supysonic.readthedocs.io
GNU Affero General Public License v3.0
260 stars 57 forks source link

startScan getScanStatus implementation #203

Closed vincentDcmps closed 3 years ago

vincentDcmps commented 3 years ago

hello,

I have tried to implement these feature could you review code and merge if you find it good.

codecov[bot] commented 3 years ago

Codecov Report

Merging #203 (6bb3cd7) into master (8cef628) will decrease coverage by 0.21%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
- Coverage   88.79%   88.57%   -0.22%     
==========================================
  Files          34       35       +1     
  Lines        3346     3370      +24     
==========================================
+ Hits         2971     2985      +14     
- Misses        375      385      +10
Impacted Files Coverage Δ
supysonic/api/scan.py 50.00% <50.00%> (ø)
supysonic/covers.py 84.31% <0.00%> (+3.92%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8cef628...6bb3cd7. Read the comment docs.

vincentDcmps commented 3 years ago

I will correct issue that you have rised, for test I can take a look out In have never write test.

vincentDcmps commented 3 years ago

I have implement test for scan endpoint following your instruction I let you resolv conflict and sorry for the commit and revert.