spl0k / supysonic

Supysonic is a Python implementation of the Subsonic server API.

https://supysonic.readthedocs.io

GNU Affero General Public License v3.0

264 stars 58 forks source link

Fixed : code quality issues #216

Closed powerexploit closed 3 years ago

powerexploit commented 3 years ago

Description

Hi 👋 I ran the DeepSource static analyzer on the forked copy of this repo and found some interesting code quality issues. This PR fixes a few of them.

Summary of Fixes

Remove unnecessary return statement
Remove unnecessary del statement from local scope
Consider merging the comparisons with 'in'
Added .deepsource.toml to fix bug risks

Type of change

[✔] Antipattern
[ ] New feature (non-breaking change which adds functionality)

Checklist:

[✔] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

codecov[bot] commented 3 years ago

Codecov Report

Merging #216 (2671be0) into master (dcef74c) will increase coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   88.57%   88.62%   +0.05%     
==========================================
  Files          35       35              
  Lines        3386     3384       -2     
==========================================
  Hits         2999     2999              
+ Misses        387      385       -2

Impacted Files	Coverage Δ
supysonic/api/annotation.py	`100.00% <ø> (ø)`
supysonic/watcher.py	`91.18% <ø> (-0.04%)`	:arrow_down:
supysonic/scanner.py	`95.25% <100.00%> (ø)`
supysonic/covers.py	`84.31% <0.00%> (+3.92%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dcef74c...2671be0. Read the comment docs.

powerexploit commented 3 years ago

@spl0k kindly review the PR.

spl0k commented 3 years ago

Hello. Interesting stuff this DeepSource thing.

The PR looks good. Could you just format it using black please?

powerexploit commented 3 years ago

Hello. Interesting stuff this DeepSource thing.

The PR looks good. Could you just format it using black please?

@spl0k thanks for response . DeepSource can automatically run black, isort autopep8 in the PRs, with the help of code auto-formatters . you can enable it after the current PR is merged and activated DeepSource.

Activating analysis will help you to continuously analyze repo for code quality issues and fix commonly occurring issues using the auto-fix feature.

To activate DeepSource you just need to follow these small steps:

Install DeepSource on your repository here.
create .deepsource.toml configuration which you can use to configure your analysis settings.

Note: This PR already have .deepsource.toml file you just need to merge this PR.
Activate analysis here.

spl0k commented 3 years ago

I've merged your fixes. As for the DeepSource integration, I'll evaluate the solution before enabling it on the repository, making my own unbiased opinion.

powerexploit commented 3 years ago

I've merged your fixes. As for the DeepSource integration, I'll evaluate the solution before enabling it on the repository, making my own unbiased opinion.

Hi @spl0k have you evaluated the solutions ?