search

spl0k / supysonic

Supysonic is a Python implementation of the Subsonic server API.
https://supysonic.readthedocs.io
GNU Affero General Public License v3.0
259 stars 57 forks source link

FR: Reach API level 1.11.0 #235

Closed ogarcia closed 1 year ago

ogarcia commented 1 year ago

The new version 4.0.0 of Ultrasonic will require a minimum API level of 1.11.0 to be able to display the album list as it needs the musicFolderId parameter of the getAlbumList endpoint. This change is due to the improvement of the offline mode, which now allows you to browse the downloaded collection as if you were online.

It would be interesting if Supysonic could reach this API level so that Ultrasonic users do not see their experience diminished at that point.

spl0k commented 1 year ago

Hello. I'll take a look. Is this musicFolderId parameter the only 1.11.0 thing Ultrasonic needs or are there other features that are mandatory?

ogarcia commented 1 year ago

Yes, for now there is no other requirement than that.

spl0k commented 1 year ago

Hello again. I've added the musicFolderId parameter on almost all endpoints that use it, and pushed the API version to 1.12.0. Don't hesitate to nudge me if you encounter any issue.

ogarcia commented 1 year ago

Sorry for the long delay, but I was away on vacation.

I just tested the latest changes and when I do the ping.view request instead of returning 1.12.0 it returns 1.10.2:

% curl 'https://server/rest/ping.view?u=user&c=Ultrasonic&f=json&p=enc:XXXXXX'
{"subsonic-response":{"status":"ok","version":"1.10.2"}}

Maybe the string needs to be changed here? https://github.com/spl0k/supysonic/blob/master/supysonic/api/__init__.py#L8

spl0k commented 1 year ago

Indeed, my bad. It should now be fixed.

ogarcia commented 1 year ago

Ok. Now it works like a charm. Thanks!!!