spla-tam / SplaTAM

SplaTAM: Splat, Track & Map 3D Gaussians for Dense RGB-D SLAM (CVPR 2024)
https://spla-tam.github.io/
BSD 3-Clause "New" or "Revised" License
1.6k stars 175 forks source link

A bug in slam_helpers.py #135

Open scpoppin1207 opened 1 month ago

scpoppin1207 commented 1 month ago

In function transformed_params2depthplussilhouette(params, w2c, transformed_gaussians) , the rendevar["colors_precomp"]uses get_depth_and_silhouette(pts_3D, w2c) which processes the first parameter as gaussians's 3D coordinates in the world coordinates.

However, in transformed_params2depthplussilhouette, it uses get_depth_and_silhouette(transformed_gaussians['means3D'], w2c) , indicating that the coordinates are transferred to world coordinates twice.

I don't whether it's a mistake.

Thanks for your reply! ☺️