search

splashblot / dronedb

Location Intelligence & Data Visualization tool
http://carto.com
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Move to ogr2ogr2.1 #5

Closed jjmata closed 7 years ago

jjmata commented 7 years ago

Do you remember what was the reason for upgrading, @iriberri? What breaks with the old one?

jjmata commented 7 years ago

/cc @apercas in case he knows ...

iriberri commented 7 years ago

Hey there! If I'm not wrong, besides from benefiting from several ogr2ogr bugfixes related to different data formats, the main reason was to be able to use the PRELUDE_STATEMENTS and CLOSING_STATEMENTS feature that allowed us to modify the statement_timeout: https://github.com/CartoDB/cartodb/blob/04998b0739050fce80c3c9adae271d0327beb8c5/services/importer/lib/importer/ogr2ogr.rb#L216-L217

Also see: https://github.com/CartoDB/cartodb/pull/6975

If I remember correctly, the old ogr2ogr version will just ignore the prelude/closing statements and it will not break, just raise some warnings at the import logs. Updating to ogr2ogr2.1 shouldn't break anything that was working before.

Hope this helps! Please let me know if you have any other questions!

jjmata commented 7 years ago

Thanks, @iriberri! We'll take a look and maybe upgrade GDAL at the same time ... do you remember what version of GDAL was being used lately?

jjmata commented 7 years ago

Fixed in a250ebd since it seemed to be affecting exports.