splattater / testTickets

0 stars 0 forks source link

Top navigation panel does not work without javascript #33

Open splattater opened 7 years ago

splattater commented 7 years ago

Not sure though, is it a bug or a feature=)

[SWIK-1018] created by darya.tarasowa

splattater commented 7 years ago

Darya Tarasowa do you mean the header or the breadcrumb navigation for the deck? Could you mark up a screenshot?

by ajames

splattater commented 7 years ago

Would the cause for this be that we do not use a complete isomorphic solution for the navigation panel?
Similarly I think the slide edit mode also depends for some features on client-side javascript only (for example, although we now use CKeditor as a node module, it does not work with javascript disabled)

by kadegraaf

splattater commented 7 years ago

My experience on experimental was that the navigation panel shows the correct text, but uses the wrong links.
It uses an already visited slide id :

/deck/{root-deck-id}/deck/{visited_slide_id}/{targed_deck_id}:{unknown_number}

by tboonx

splattater commented 7 years ago

Sorry for late response - the header panel was not even visible if you switch off the javascript in browser. Now it is visible (I think I've fixed that - the issue was in the way how we set the screen resolution for responsibility), however the Sign In button does not work. I do not know if this is crucial for now - probably not, but still I thought that the idea is that SlideWiki is completely isomorphic - no?..

by darya.tarasowa

splattater commented 7 years ago

OK then the links need to be fixed.
Re isomorhpic: You are right - it should be completely run without javascript on client side (with exceptions like slide editor) but all the modals (semantic-ui and sweetalert2 modals) need javascript in order to be shown/hidden. The modal topic should be discussed.

by tboonx

splattater commented 7 years ago

Kurt Junghanns is this still an open issue or can it be closed? Please could you check.

by ajames

splattater commented 7 years ago

The top panel is visible and the two links are working. But the dropdown under the user-avatar needs JavaScript and does not work without it. (will not open)

by tboonx