search

splattater / testTickets

0 stars 0 forks source link

No error handling when looking for non-existing deck/slide/etc.. in platform #37

Open splattater opened 8 years ago

splattater commented 8 years ago

When navigating to a non-existing deck/slide, slidewiki will open up the deck-page without any content instead of showing a 404 message.
e.g., https://platform.experimental.slidewiki.org/deck/423424
Actually it should do something like on https://platform.experimental.slidewiki.org/user/423424

[SWIK-555] created by kadegraaf

splattater commented 8 years ago

Hi Klaas,

PS: https://slidewiki.atlassian.net/wiki/display/SWIK/Error+types+and+corresponding+messages?focusedCommentId=19464198#comment-19464198

The developer responsible for the action/service development (or who has worked on action/service) is responsible for adding the already developed existing error handling code. It would be anti-pattern (for me) to keep adding error handling on the action code others have developed.

Pls see: line 30 to 32 which can be copied in the respective action to enable already developed error handling: https://github.com/slidewiki/slidewiki-platform/blob/master/actions/decktree/loadDeckTree.js#L30

This can be used in respective actions to handle service related errors.

by vinaymodi

splattater commented 8 years ago

Hi Vinay,
Thanks for the information!
Indeed we agreed that everyone implements error handling in their components.

by kadegraaf

splattater commented 7 years ago

This bug is still an issue. For example, https://platform.experimental.slidewiki.org/deck/3097 creates a empty deck view with a 505 error. It is more likely that users will end up at empty decks due to the migration of decks.

by ajames

splattater commented 6 years ago

Updated the bug description and verified that it is still a problem

by roymeissner