search

splewis / csgo-executes

CS:GO SourceMod plugin for a site-execute practice gamemode
GNU General Public License v3.0
60 stars 22 forks source link

Add preference menu for aug and sg #26

Closed dcowen91 closed 5 years ago

dcowen91 commented 5 years ago

Implements the feature for issue #25.

This makes it so that players can opt in to receiving scoped rifles on CT & T side. If they opt in, then there is a 25% chance that they will receive an sg/aug instead of an m4/ak. I'm not married to this percentage at all if you have any feedback on how to better incorporate this feature.

splewis commented 5 years ago

If they opt in, then there is a 25% chance that they will receive an sg/aug instead of an m4/ak.

I think it'd be preferable to just have a generic rifle selection for both sides. CTs currently can pick silenced/unsilenced m4, the AUG should just be another entry.

dcowen91 commented 5 years ago

CTs currently can pick silenced/unsilenced m4, the AUG should just be another entry.

That makes sense. My only concern with letting every CT potentially have an AUG is that it might result in an unintended buff to CT sides, since the AUG makes certain angles a lot easier to hold.

I'll go ahead and implement a generic rifle selection as you suggested and update this PR.

dcowen91 commented 5 years ago

I've implemented the rifle selection for CT and T sides. Do note however that I have not been able to test these changes- I'm primarily a Windows dev and there are some compatibility issues I'm facing with running smbuilder inside Windows Subsystem for Linux. I'll keep banging my head against those issues, but wanted to update the PR in the meantime.

splewis commented 5 years ago

I've implemented the rifle selection for CT and T sides. Do note however that I have not been able to test these changes- I'm primarily a Windows dev and there are some compatibility issues I'm facing with running smbuilder inside Windows Subsystem for Linux. I'll keep banging my head against those issues, but wanted to update the PR in the meantime

Mostly looks good, a few notes.

You don't necessarily have to use smbuilder to compile this, you can compile it the 'standard way' for compiling sourcemod plugins (spcomp executes.sp or such). I mostly just use it to simplify packaging for servers & releases. (the travis.ci builds here are running the compilation too, so you can test it that way if you must :p)

dcowen91 commented 5 years ago

Thanks for the feedback! I addressed the comments and was finally able to test it! :)

image

splewis commented 5 years ago

Thanks for testing. One last nitpick.