search

splewis / csgo-multi-1v1

CS:GO Sourcemod plugin to create multi-1v1 arena servers
GNU General Public License v3.0
278 stars 68 forks source link

New natives to check states + renaming + bugfix #256

Closed iNilo closed 2 years ago

iNilo commented 4 years ago

🛠️ Renamed: Multi1v1_HasRoundTypeSpecificRating to Multi1v1_IsRoundTypeRanked To improve readability and to avoid possible confusion with Multi1v1_BlockRatingChanges and Multi1v1_UnblockRatingChanges

🐞 Fixed #255

Added 4 other natives to check states (for cross plugin activity)

🆕 Multi1v1_AreRatingChangesBlocked 🆕 Multi1v1_AreChatMessagesBlocked 🆕 Multi1v1_AreMVPStarsBlocked 🆕 Multi1v1_AreArenaDonesBlocked

splewis commented 4 years ago

I like the new natives, but I think backwards compatibility should be maintained with the Multi1v1_HasRoundTypeSpecificRating change here. The rename is fine, but we'll need the old native + new native to maintain compatibility.

iNilo commented 4 years ago

@splewis I fully agree on the backwards compatibility part. But given the fact that the renamed native was introduced 2 days ago in #251 and no new github release was added it was worth a shot.

Still want me to add a commit to ensure backwards compatibility?

iNilo commented 4 years ago

@splewis added backwards compatibility.

splewis commented 4 years ago

Argh, I'm sorry - I forgot that was a new native. Yeah, backwards compatibility is definitely overkill. Sorry - we should go with the original PR.