search

splewis / csgo-practice-mode

CS:GO Sourcemod plugin for private team/individual practice servers
GNU General Public License v3.0
455 stars 70 forks source link

Prevent autostart from re-enabling practice mode after the user has explicity disabled it #221

Closed Lidbetter closed 2 years ago

Lidbetter commented 2 years ago

https://github.com/splewis/csgo-practice-mode/issues/219

I may also need to update compaison checks - not sure how sourcepawn handles that (having issues with building locally to check for errors), will address if needed when I am able to build and test locally.

Is this general approach acceptable?

Lidbetter commented 2 years ago

I have not tested as I only have my macbook with me (no linux vm and a very slow connection) but I think it should be close, I will compile and test when I am back at my desktop sometime in the next few days

mrc4tt commented 2 years ago

I have not tested as I only have my macbook with me (no linux vm and a very slow connection) but I think it should be close, I will compile and test when I am back at my desktop sometime in the next few days

Hi @Lidbetter.

I did test it, and it works (if I disconnect from the gameserver) - What with, if you switch map - where practicemode is still loaded (and not unloaded), so clients will not get "grenades" on change-map, but only at "reconnect". What with change-map?

Lidbetter commented 2 years ago

This is ready for review

Lidbetter commented 2 years ago

@splewis bumping incase you missed earler review request