splewis / csgo-pug-setup

CS:GO Sourcemod plugin for setting up private pug/10man games
GNU General Public License v3.0
412 stars 90 forks source link

Instant runoff vote #392

Closed Siniiitchibo closed 1 year ago

Siniiitchibo commented 2 years ago

Instant runoff vote working but still with 1 bug... After all players have entered their 3 preferences. Hit message "Vote over... {1} won!" was showed for 1 sec. and after that the countdown continues as well as after map change.

splewis commented 2 years ago

Can you reproduce this behavior and post the plugin version? I can't reproduce this.

There supposed to be a builtin 10-second delay there.

Siniiitchibo commented 2 years ago

It was last version 2.0.7 I can make a video if u want, will be better i think

Siniiitchibo commented 2 years ago

look at the hint message, countdown timer still working as well as after map change.

https://youtu.be/zpiPzClWKec

splewis commented 2 years ago

Have you checked for any error logs under addons/sourcemod/logs?

Siniiitchibo commented 2 years ago

without error message.

splewis commented 2 years ago

I believe I see the issue; this can happen if all players finish voting before the timeout. The fix is in the latest build @ https://ci.splewis.net/job/csgo-pug-setup/lastBuild/ if you want to try it. (you just need the updated addons/sourcemod/plugins/pugsetup.smx file)

Siniiitchibo commented 2 years ago

yeah it`s perfect...thx so much bro ;)