search

splewis / get5

CS:GO Sourcemod plugin for competitive matches/scrims
GNU General Public License v3.0
559 stars 176 forks source link

[Feature Request]: Increase get5_demo_upload_url max length #1034

Open FlowingSPDG opened 11 months ago

FlowingSPDG commented 11 months ago

Prereleases & Documentation

Get5 Version

v0.15.0

The Feature

Currently I am building cloud based management system that manages srcds and get5 matches. I am planning to upload demo through Google Cloud Run or something, but it has body length limit(32MiB) for HTTP/1. So I am going to let srcds upload demo cloud storage directly, but url length would be about 900 chars. is it possible to increase them?

Thank you for developing and maintaining great plugin for CSGO community!

FlowingSPDG commented 11 months ago

Here's match schema for get5_loadmatch_url . https://got5-match-loader-op4haeqloa-an.a.run.app/get5/match/329523134

nickdnk commented 11 months ago

As far as I can tell it's just a matter of increasing this constant: https://github.com/splewis/get5/blob/development/scripting/get5/util.sp#L6

I think going to 1025 would probably be fine. I can change this later today for 0.15.1.

FlowingSPDG commented 11 months ago

I made PR for it, let me know if we need additional modification!

1035