"series_start" event never occurs

splewis / get5

CS:GO Sourcemod plugin for competitive matches/scrims

GNU General Public License v3.0

558 stars 175 forks source link

"series_start" event never occurs #133

Closed EAbychkov closed 7 years ago

EAbychkov commented 7 years ago

Expected behavior

"series_start" event raised at the beginning of the match (for instance when the first player connected)

Actual behavior

"series_start" event never occurs

Steps to reproduce

Plugin version: latest (build #315 (24.03.2017 0:28:06))
Sourcemod version: latest

splewis commented 7 years ago

I can't reproduce this, the event fired in my test; it fires when the match config is loaded: https://github.com/splewis/get5/blob/3c2b5e6d3c9617c04be8aed31475544e78c73dbf/scripting/get5/matchconfig.sp#L110

EAbychkov commented 7 years ago

Ohh sorry, my bad, am I understand this correctly, "series_end" will fire when the match is over, no matter how many maps I have (BO1, BO2 ...) it will fire only one time at the end just before kick all the players?

miped commented 7 years ago

Yes that's correct.

splewis commented 7 years ago

I think this is settled then.