splewis / get5

CS:GO Sourcemod plugin for competitive matches/scrims
GNU General Public License v3.0
557 stars 175 forks source link

Custom logo #161

Closed iSach closed 2 years ago

iSach commented 7 years ago

Hello,

I made earlier an issue on get5-web and you told me I could put the logo in csgo/resource/flash/econ/tournaments/teams/ So I did, I put my logo ar.png in it.

Then I made my team_argon file: https://hastebin.com/zidanekewu.pl

I tried:

Nothing works, it just shows empty logo.

I searched on the wiki but couldn't find how to do.

Thanks in advance, sach.

Technoblazed commented 7 years ago

Did you add the logo config file as well?

splewis commented 7 years ago

I don't know what a "logo config file" is. You did all you need to.

Note that you might have to rejoin the server if you just loaded the match. The reason is that the server doesn't add the logo file to the download table until the logo is needed, so clients won't download it yet.

You could try loading the match then joining, and making sure your client downloaded the file (to the same directory as the server).

iSach commented 7 years ago

I did mp_loadteam_1 team_argon.cfg then I rejoined, I tried changing the country to France, it changed it but the logo was still not appearing.

I'll try loading then joining again, but is it normal the folder econ (and tournaments, teams in it) didn't exist? I had to create it not sure if it's normal.

Technoblazed commented 7 years ago

On your gameserver in the logo directory, create a file called 'ar.cfg', inside that file write 'ar'

splewis commented 7 years ago

I think there's some confusion here.

@iSach

mp_loadteam1 isn't a command in the game, or get5. get5_loadteamis, though. Loading the configs before joining the server sounds like it could still be the culprit.

@Technoblazed

I'm not sure where you're getting this from. Adding that file won't do anything for get5: https://github.com/splewis/get5/blob/master/scripting/get5/matchconfig.sp#L994

Technoblazed commented 7 years ago

I read a while ago that the file was needed for logos in general, guess it's not the case here /shrug :^)

TandelK commented 7 years ago

I know what is the issue here, They have to have files in their Game Files also which is by default not downloaded by the Get5 . You will have to do it either Manually or via Plugins.

Make sure you also have your custom logo files in your game directory at /csgo/resource/flash/econ/tournaments/teams . If there is no folder like this , i would recommend you to use https://forums.alliedmods.net/showthread.php?t=258206 . This will add your Logo to Download from server files.

TandelK commented 7 years ago

By default Game Logo directory is not able to send upload and download from the server, The plugin which i gave above will automatically add Logo for downloading on client side. Also you can use FastDL if you have it. Make sure to create directory at /folderpath/resource/flash/econ/tournaments/teams/yourlogo.png

splewis commented 7 years ago

There should be no need for that plugin. Like I've already mentioned, get5 adds the logo files to the download tables, which is exactly what that plugin does.

TandelK commented 7 years ago

@splewis I am using Get5-Web Panel for Matches and also i have the logos in /static/img/logos/file.png ,and also the server has file.png in resource/econ/flash/tournaments/teams/ path but still doesnt seems to download the logo files for clients. Also sv_allowupload is 1 and sv_allowdownload is 1

xe1os commented 6 years ago

@TandelK i have tested all the screnarios. Actually there is no need of .cfg file for logos, https://forums.alliedmods.net/showthread.php?t=258206 plugin is not required. @splewis There seems to be a bug. We have to cancel and re-create the match for the plugin to download logos.

Guacalaquerico commented 6 years ago

I just configured get5 with the Team Logo Manager plugin. It downloads the logo even if the default match doesn't need it, but it works perfectly every time I load a match that uses a custom logo.

I'll try without the plugin, but so far it's comfy because you just drop the file in server and FastDL and the Team Logo plugin adds it to the download table.

I used the .cfg file, just in case

You have logo.png You put it on the folder /folderpath/resource/flash/econ/tournaments/teams/, along the .cfg file

Logo: logo.png Config: logo.cfg (Inside put the name of the team, like "Team Super Logo" but isn't needed tbh).

It worked for me this way.

splewis commented 6 years ago

FYI: I'm still not looking into fixing this, but the issue may just be that files aren't added to the download table until match config loading, which may not work anymore. A simple fix may be just to add all custom logos earlier (I'm not sure where, OnPluginStart or similar). It will just result in players getting forced to possibly download extra files they won't use.

TandelK commented 6 years ago

Yeah it will be wonderful if the Logos are downloaded as per match config itself and run as much as less plugins while making the Servers.

inferno9200 commented 5 years ago

I fixed this issue by upload a 128x128 .png format logo both in get5/static/img/logos and csgo/resource/flash/econ/tournaments/teams/ of the server root directory , and i am also using the plugin which @TandelK Mentioned above , it is working for me without creating any config file for the logos

TandelK commented 5 years ago

@inferno9200 The thing is if you use Team Logo Manager it will work but the idea of Splewis is to keep the Server Plugins minimal with Get5 so he integrated the Team Logo Download code itself in Get5. The issue that everyone is facing that if in Get5 it doesnt download on the server if it Windows Server as it does not have format of creating new directory while Linux system has a access but requires write permission by the plugin to create new folder inside CSGO. If you just use Get5 and able to download the logos on both Client side as well as Server side let me also know.

Also like Splewis mentioned above that it should download as soon as the server starts but the plugin is calling Logos from Remote Directory and also json file for panel is called later on it will require some recoding.

inwady commented 5 years ago

Hello, I have image "t2.png" on my client CSGO: image 2019-03-03 14 45 29

My config with logo param (in docker): image

Unfortunately, when match is started there is empty image. What am I doing wrong?

TandelK commented 5 years ago

Is it located on the server also ? Also make sure the size o the logo are as per logo standards which are like 64x64 in png format in less than 250 kb size and also you will be not able to see logo directly , You can view them in Scoreboard in game or via Spectator only. If you are playing you wont be able to see it. It also display when the round ends.

st1ng2 commented 5 years ago

I have my own solution to show logos to spectators and players. But you need convert all logo files to vector (svg) and force download files to clients using plugin. If you interested I will make an instruction.

mpavel27 commented 3 years ago

I have my own solution to show logos to spectators and players. But you need convert all logo files to vector (svg) and force download files to clients using plugin. If you interested I will make an instruction.

Could you make an instruction please, I really need some help with this plugin and I think that will help me.