splewis / get5

CS:GO Sourcemod plugin for competitive matches/scrims
GNU General Public License v3.0
557 stars 174 forks source link

Add coaches to ready system via optional parameter #861

Closed nickdnk closed 2 years ago

nickdnk commented 2 years ago

This fixes https://github.com/splewis/get5/issues/201.

~I also got rid of the "format clan tags every single second no matter the game state" code that was running.~

nickdnk commented 2 years ago

So I've thought about this, and I think trying to figure out all possible places where a clan tag update could be needed is a lot more complicated than just letting the function run every second, even though I really don't like that approach much either - but it seems to work fine. I suppose having it constantly check also makes sure that people cannot change their tags during a match.

I'm considering rolling back the changes for the clan tag update, and just sticking to the coach inclusion part, which was what I originally set out to fix anyway.